build/ops: rpm: put mgr python build dependencies in make_check bcond

[smithfarm]

Fixes: http://tracker.ceph.com/issues/20425

Quoting from the tracker:

Some dependencies - notably the mgr dependencies "python-cherrypy", "python-pecan" and "python-werkzeug" - are only needed to run "make check". Since these dependencies bring in a pretty long list of packages (dependencies of dependencies of dependencies. . .) it would make sense to put them inside the "make_check" bcond so RPM builds that do not run "make check" (the default) would not pull in all these python modules that are not used.

There is one wrinkle, though: the bcond is "off" by default, so install-deps.sh will need to activate it before parsing the spec file for dependencies, otherwise "run-make-check.sh" will fail due to missing dependencies.

Note that this is RPM-only (at least for now) since the "make_check" bcond itself if RPM-only.

[smithfarm]

Do we know of any other build dependencies that are only needed for "make check" and could be moved into the conditional?

[tchaikov]

the dashboard ceph-mgr plugin depends on cherrypy at run-time, and the restful plugin depends on werkzeug.

so we need them unless they are packaged separately.

[tserong]

They're still there as runtime Requires, so that should be fine...?

[b-ranto]

This just moves the build-time dependencies, the runtime dependencies are still in place. I would like to see a full jenkins builder job for this though.

[tchaikov]

ahh, right! i missed that!

[smithfarm]

Pushed to Shaman: https://shaman.ceph.com/builds/ceph/wip-20425/

[smithfarm]

@b-ranto Shaman is green

[liewegas]

http://pulpito.ceph.com/sage-2017-07-17_17:34:45-rados-wip-sage-testing-distro-basic-smithi/