Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kraken: osd: unlock sdata_op_ordering_lock with sdata_lock hold to avoid missing wakeup signal #15962

Merged
merged 1 commit into from Jul 6, 2017
Merged

kraken: osd: unlock sdata_op_ordering_lock with sdata_lock hold to avoid missing wakeup signal #15962

merged 1 commit into from Jul 6, 2017

Conversation

asheplyakov
Copy link

kraken: osd: unlock sdata_op_ordering_lock with sdata_lock hold to av…
ff19977 
…oid missing wakeup signal

Based on commit bc68338. The OSD code has
been refactored a lot since Kraken, hence cherry-picking that patch introduces
a lot of unrelated changes, and is much more difficult than reusing the idea.

Fixes: http://tracker.ceph.com/issues/20443

Signed-off-by: Alexey Sheplyakov <asheplyakov@mirantis.com>
@cbodley cbodley added this to the kraken milestone Jun 28, 2017
@smithfarm
Copy link
Contributor

Jenkins re-test this please

@smithfarm smithfarm changed the title kraken: osd: unlock sdata_op_ordering_lock with sdata_lock hold to avoid missing wakeup signal [DNM] kraken: osd: unlock sdata_op_ordering_lock with sdata_lock hold to avoid missing wakeup signal Jun 30, 2017
@smithfarm
Copy link
Contributor

Marking DNM until we can get this past make check.

@smithfarm
Copy link
Contributor

@asheplyakov Please rebase to latest kraken to pick up #16069 - then you can remove DNM.

@smithfarm
Copy link
Contributor

Jenkins re-test this please

@smithfarm smithfarm changed the title [DNM] kraken: osd: unlock sdata_op_ordering_lock with sdata_lock hold to avoid missing wakeup signal kraken: osd: unlock sdata_op_ordering_lock with sdata_lock hold to avoid missing wakeup signal Jul 3, 2017
@smithfarm
Copy link
Contributor

@asheplyakov Nevermind, rebase not necessary (Jenkins merges into latest base branch before starting the test).

Jenkins re-test this please

@smithfarm
Copy link
Contributor 

-- BUILDING Boost Libraries at j 8
./bootstrap.sh: line 196: ./tools/build/src/engine/build.sh: No such file or directory
Building Boost.Build engine with toolset ... 
Failed to build Boost.Build build engine
Consult 'bootstrap.log' for more details
CMake Error at /usr/share/cmake/Modules/FindBoost.cmake:1138 (message):
  Unable to find the requested Boost libraries.

  Unable to find the Boost header files.  Please set BOOST_ROOT to the root
  directory containing Boost or BOOST_INCLUDEDIR to the directory containing
  Boost's headers.
Call Stack (most recent call first):
  CMakeLists.txt:472 (find_package)

@smithfarm
Copy link
Contributor

Jenkins re-test this please

@smithfarm smithfarm requested a review from jdurgin July 5, 2017 16:44
@smithfarm
Copy link
Contributor

@jdurgin This passed a rados suite at http://tracker.ceph.com/issues/19009#note-51http://tracker.ceph.com/issues/19009#note-51 with two failures that I believe are unrelated. Please review/approve the PR if you agree it can be merged.

@smithfarm smithfarm merged commit f45de0f into ceph:kraken Jul 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdurgin jdurgin jdurgin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
kraken
4 participants
@asheplyakov @smithfarm @jdurgin @cbodley