Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kraken: rbd: refuse to use an ec pool that doesn't support overwrites #16096

Merged
merged 5 commits into from Jul 19, 2017
Merged

kraken: rbd: refuse to use an ec pool that doesn't support overwrites #16096

merged 5 commits into from Jul 19, 2017

Conversation

smithfarm
Copy link
Contributor

Jason Dillaman added 3 commits July 4, 2017 10:44
@smithfarm
librbd: avoid duplicating librados IoCtx objects if not needed
f1cf946 
This introduces the potential for shutdown race conditions within
the unit tests.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit cc5ac6a)
@smithfarm
librbd: removed legacy state machine callbacks from CreateRequest
fbd2969 
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 8d79bf2)

Conflicts:
    src/librbd/image/CreateRequest.cc - kraken does not have 5f2689b
@smithfarm
librbd: clean up debug messages within image create state machine
8ed81b0 
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit d4e27c4)
@smithfarm smithfarm self-assigned this Jul 4, 2017
@smithfarm smithfarm added this to the kraken milestone Jul 4, 2017
@smithfarm
librbd: image create validates that pool supports overwrites
fa88fc7 
Fixes: http://tracker.ceph.com/issues/19081
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit a16beba)

Conflicts:
    src/librbd/image/CreateRequest.cc - kraken uses create_rados_ack_callback;
        in master, this has been renamed ceph_rados_callback
@smithfarm
Copy link
Contributor Author 

[       OK ] TestLibRBD.TestIOToSnapshot (5 ms)
[ RUN      ] TestLibRBD.TestClone
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/run-rbd-unit-tests.sh: line 9: 26968 Segmentation fault      (core dumped) unittest_librbd

@smithfarm smithfarm changed the title kraken: rbd: refuse to use an ec pool that doesn't support overwrites [DNM] kraken: rbd: refuse to use an ec pool that doesn't support overwrites Jul 4, 2017
@smithfarm
Copy link
Contributor Author

Jenkins re-test this please

@smithfarm
Copy link
Contributor Author

Segfault in unittest_librbd is reproducible.

@smithfarm
Copy link
Contributor Author

@trociny This PR causes unittest_librbd to segfault - can you take a look?

@trociny
Copy link
Contributor

trociny commented Jul 5, 2017

@smithfarm You also need c35d307

@smithfarm
test: added missing IoCtx copy/assignment methods in librados_test_stub
6d2f959 
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit c35d307)
@smithfarm smithfarm changed the title [DNM] kraken: rbd: refuse to use an ec pool that doesn't support overwrites kraken: rbd: refuse to use an ec pool that doesn't support overwrites Jul 5, 2017
@smithfarm
Copy link
Contributor Author

@trociny That did the trick - thanks!!!

@smithfarm
Copy link
Contributor Author

@trociny @dillaman This passed an rbd suite in http://tracker.ceph.com/issues/19009#note-66

Please review.

dillaman
dillaman approved these changes Jul 19, 2017
View reviewed changes
Copy link

@dillaman dillaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@smithfarm smithfarm merged commit 72c3a04 into ceph:kraken Jul 19, 2017
@smithfarm smithfarm deleted the wip-19336-kraken branch July 19, 2017 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dillaman dillaman dillaman approved these changes

@trociny trociny Awaiting requested review from trociny

Assignees

@smithfarm smithfarm

Labels
bug-fix rbd
Projects
None yet
Milestone
kraken
3 participants
@smithfarm @trociny @dillaman