Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kraken: rbd: refuse to use an ec pool that doesn't support overwrites #16096

Merged
merged 5 commits into from Jul 19, 2017

Conversation

Projects
None yet
3 participants
@smithfarm
Copy link
Contributor

commented Jul 4, 2017

dillaman added some commits Mar 2, 2017

librbd: avoid duplicating librados IoCtx objects if not needed
This introduces the potential for shutdown race conditions within
the unit tests.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit cc5ac6a)
librbd: removed legacy state machine callbacks from CreateRequest
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 8d79bf2)

Conflicts:
    src/librbd/image/CreateRequest.cc - kraken does not have 5f2689b
librbd: clean up debug messages within image create state machine
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit d4e27c4)

@smithfarm smithfarm self-assigned this Jul 4, 2017

@smithfarm smithfarm added this to the kraken milestone Jul 4, 2017

@smithfarm smithfarm added bug fix core rbd and removed core labels Jul 4, 2017

librbd: image create validates that pool supports overwrites
Fixes: http://tracker.ceph.com/issues/19081
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit a16beba)

Conflicts:
    src/librbd/image/CreateRequest.cc - kraken uses create_rados_ack_callback;
        in master, this has been renamed ceph_rados_callback

@smithfarm smithfarm force-pushed the smithfarm:wip-19336-kraken branch from 9ba593d to fa88fc7 Jul 4, 2017

@smithfarm

This comment has been minimized.

Copy link
Contributor Author

commented Jul 4, 2017

[       OK ] TestLibRBD.TestIOToSnapshot (5 ms)
[ RUN      ] TestLibRBD.TestClone
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/run-rbd-unit-tests.sh: line 9: 26968 Segmentation fault      (core dumped) unittest_librbd

@smithfarm smithfarm changed the title kraken: rbd: refuse to use an ec pool that doesn't support overwrites [DNM] kraken: rbd: refuse to use an ec pool that doesn't support overwrites Jul 4, 2017

@smithfarm

This comment has been minimized.

Copy link
Contributor Author

commented Jul 4, 2017

Jenkins re-test this please

@smithfarm

This comment has been minimized.

Copy link
Contributor Author

commented Jul 5, 2017

Segfault in unittest_librbd is reproducible.

@smithfarm

This comment has been minimized.

Copy link
Contributor Author

commented Jul 5, 2017

@trociny This PR causes unittest_librbd to segfault - can you take a look?

@trociny

This comment has been minimized.

Copy link
Contributor

commented Jul 5, 2017

@smithfarm You also need c35d307

test: added missing IoCtx copy/assignment methods in librados_test_stub
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit c35d307)

@smithfarm smithfarm changed the title [DNM] kraken: rbd: refuse to use an ec pool that doesn't support overwrites kraken: rbd: refuse to use an ec pool that doesn't support overwrites Jul 5, 2017

@smithfarm

This comment has been minimized.

Copy link
Contributor Author

commented Jul 5, 2017

@trociny That did the trick - thanks!!!

@smithfarm smithfarm requested review from trociny and dillaman Jul 19, 2017

@smithfarm

This comment has been minimized.

Copy link
Contributor Author

commented Jul 19, 2017

@trociny @dillaman This passed an rbd suite in http://tracker.ceph.com/issues/19009#note-66

Please review.

@dillaman
Copy link
Contributor

left a comment

👍

@smithfarm smithfarm merged commit 72c3a04 into ceph:kraken Jul 19, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@smithfarm smithfarm deleted the smithfarm:wip-19336-kraken branch Jul 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.