kraken: cephfs: mds is crushed, after I set about 400 64KB xattr kv pairs to a file #16103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After I have set about 400 64KB xattr kv pair to a file, mds is crashed. Every time I try to start mds, it will crash again. The root reason is write_buf._len overflowed when doing Journaler::append_entry(). This patch try to fix this problem through the following changes: 1. limit file/dir's xattr size 2. throttle journal entry append operations Fixes: http://tracker.ceph.com/issues/19033 Signed-off-by: Yang Honggang joseph.yang@xtaotech.com (cherry picked from commit eb915d0)
|
@jcsp This PR passed an fs run at http://tracker.ceph.com/issues/19009#note-57 (there were some failures that required a fix - applied via #16114 and passed on rerun). Please review/approve/merge the PR if you agree it can be merged. |
|
@batrick This PR passed another fs suite at http://tracker.ceph.com/issues/19009#note-67 Please review. |
batrick
approved these changes
Jul 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/19674