kraken: osd: FAILED assert(object_contexts.empty()) (live on master only from Jan-Feb 2017, all other instances are different) #16132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has always been a bug, but until 68defc2, nothing deleted those contexts without calling complete(). Fixes: http://tracker.ceph.com/issues/18809 Bug shadowed until: 68defc2 Signed-off-by: Samuel Just <sjust@redhat.com> (cherry picked from commit 91b7423)
We only flush the ObjectStore callbacks, not everything else. Thus, there isn't a guarrantee that the obc held by pull_complete_info will be cleaned up before the Flush callback is triggered. Instead, just defer clearing the pull state until the callback (it'll be cleaned up during the interval change) and remove the ObjectContext from pull_complete_info. Introduced: 68defc2 Fixes: http://tracker.ceph.com/issues/18927 Signed-off-by: Samuel Just <sjust@redhat.com> (cherry picked from commit 51eee55)
jdurgin
approved these changes
Jul 5, 2017
smithfarm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/20522
http://tracker.ceph.com/issues/20523
Fixes bugs known to have been introduced by #14616