kraken: osd: ENOSPC seen even with osd_failsafe_full_ratio passed #16134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@liewegas @jdurgin @dzafman This passed a rados suite at http://tracker.ceph.com/issues/19009#note-62 Please review. |
dzafman
suggested changes
Jul 18, 2017
src/mon/PGMonitor.cc
Outdated
| float diff = max_osd_usage - min_osd_usage; | ||
| if (diff > g_conf->mon_warn_osd_usage_min_max_delta) { | ||
| ostringstream ss; | ||
| ss << "difference between min (" << roundf(min_osd_usage*1000.0)/100.0 |
There was a problem hiding this comment.
There was follow on fix for this generated output.
Signed-off-by: David Zafman <dzafman@redhat.com> (cherry picked from commit 50cfe03)
Signed-off-by: David Zafman <dzafman@redhat.com> (cherry picked from commit 830cc7a)
…cent (10%) Signed-off-by: David Zafman <dzafman@redhat.com> (cherry picked from commit c8004e6)
Fixes: http://tracker.ceph.com/issues/16878 Signed-off-by: David Zafman <dzafman@redhat.com> (cherry picked from commit 78adb70)
This really only works after journal drains because we adjust for the journal. Signed-off-by: David Zafman <dzafman@redhat.com> (cherry picked from commit 26dcb59)
…fs min reserved This fixes OSD crashes because checking osd_failsafe_full_ratio won't work without accurate statfs information. Signed-off-by: David Zafman <dzafman@redhat.com> (cherry picked from commit 72d83f8)
Clean up option naming. Signed-off-by: Sage Weil <sage@redhat.com> (cherry picked from commit 489e810)
Fixes: http://tracker.ceph.com/issues/20544 Caued by: 489e810 Signed-off-by: David Zafman <dzafman@redhat.com> (cherry picked from commit 56f9808) Conflicts: src/mon/PGMap.cc: kraken has no daa0793 so we manually apply the changes from 56f9808 to src/mon/PGMonitor.cc instead of to src/mon/PGMap.cc
smithfarm
force-pushed
the
wip-19340-kraken
branch
from
839058e
to
c6542ac
Compare
|
@dzafman This passed another rados suite at http://tracker.ceph.com/issues/19009#note-71 and I added the commit you asked for. Please take a look. |
dzafman
approved these changes
Jul 26, 2017
smithfarm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/19340
http://tracker.ceph.com/issues/19841
http://tracker.ceph.com/issues/20672