rgw: add tail tag to track tail instance #16145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattbenjamin
approved these changes
Jul 7, 2017
|
@yehudasa what's next for this one? |
Use tail_tag instead of idtag. The tail_tag is modified when either creating a new tail, or adding a refcount to the tail (e.g., when copying object). When just modifying the object's head, tail_tag should remain the same. The gc will then use the tail_tag (if exists, idtag if not) as the refcount id. Fixes: http://tracker.ceph.com/issues/20234 Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
|
@mattbenjamin doesnt seem to have any regressions in teuthology: http://pulpito.ceph.com/yehudasa-2017-08-20_02:43:42-rgw-wip-yehuda-testing---basic-smithi/ |
|
jenkins test this please |
oritwas
approved these changes
Sep 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use tail_tag instead of idtag. The tail_tag is modified when either
creating a new tail, or adding a refcount to the tail (e.g., when
copying object). When just modifying the object's head, tail_tag
should remain the same. The gc will then use the tail_tag (if
exists, idtag if not) as the refcount id.
Fixes: http://tracker.ceph.com/issues/20234
Signed-off-by: Yehuda Sadeh yehuda@redhat.com