kraken: rgw: multisite: rest api fails to decode large period on 'period commit' #16161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We currently read all user input for a few apis accepting xml, avoid doing this and error out early, most s3 apis limit to about 1000 xml entries, make this configurable via a new config param, `rgw_max_put_param_size` defaulting to 1MB. Also modified `rgw_rest_read_all_input` with an additional param to not allow for chunked uploads, though we error out in a better way by responding with content length required rather than S3's 501 if chunked is set. This also adds the same behavior in RGWPutCORS reusing `rgw_rest_read_all_input`, and using a data_deleter to manage the char* Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com> rgw: rgw_rest_s3: make PUT CORS accept only a configured max input Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com> (cherry picked from commit 35375b7)
testing with 3 zonegroups and 3 zones each, the period json grew larger than 4k and caused decode failures on period commit updated to use the new config variable rgw_max_put_param_size Fixes: http://tracker.ceph.com/issues/19505 Signed-off-by: Casey Bodley <cbodley@redhat.com> (cherry picked from commit 7f2871f)
if no zonegroup endpoints are set, fall back to master zone endpoints Fixes: http://tracker.ceph.com/issues/19488 Signed-off-by: Casey Bodley <cbodley@redhat.com> (cherry picked from commit 92f63c6)
local dest_url variable was shadowing the one in the enclosing scope, so the changes were not applied and no Location header was written on redirect Fixes: http://tracker.ceph.com/issues/19488 Signed-off-by: Casey Bodley <cbodley@redhat.com> (cherry picked from commit 542e188)
Fixes: http://tracker.ceph.com/issues/19746 Signed-off-by: Casey Bodley <cbodley@redhat.com> (cherry picked from commit 8a459c7)
Fixes: http://tracker.ceph.com/issues/20244 Signed-off-by: Casey Bodley <cbodley@redhat.com> (cherry picked from commit b8272f3)
smithfarm
force-pushed
the
wip-19614-kraken
branch
from
2ea75d1
to
d52aeec
Compare
|
@oritwas @cbodley This passed a rgw suite at http://tracker.ceph.com/issues/19009#note-65 with two valgrind-related failures that I'm currently re-running. Please review. |
|
@yehudasa This passed a rgw suite at http://tracker.ceph.com/issues/19009#note-65 with two valgrind-related failures that I'm currently re-running. Please review. |
cbodley
approved these changes
Jul 19, 2017
smithfarm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/19614
http://tracker.ceph.com/issues/19616
http://tracker.ceph.com/issues/19776
http://tracker.ceph.com/issues/20293