New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon/Monitor: recreate mon session if features changed #16230

Merged
merged 4 commits into from Jul 10, 2017

Conversation

Projects
None yet
2 participants
@jecluis
Member

jecluis commented Jul 9, 2017

Fixes: http://tracker.ceph.com/issues/20433

Signed-off-by: Joao Eduardo Luis <joao@suse.de>

jecluis added some commits Jul 9, 2017

mon/Session: fix some annoying spacing
Signed-off-by: Joao Eduardo Luis <joao@suse.de>
mon/Paxos: fix annoying formatting spacing
Signed-off-by: Joao Eduardo Luis <joao@suse.de>
mon/Monitor: list sessions via admin socket
Signed-off-by: Joao Eduardo Luis <joao@suse.de>

@jecluis jecluis added this to the luminous milestone Jul 9, 2017

@jecluis jecluis requested a review from liewegas Jul 9, 2017

mon/Monitor: recreate mon session if features changed
Fixes: http://tracker.ceph.com/issues/20433

Signed-off-by: Joao Eduardo Luis <joao@suse.de>
s->put();
s = nullptr;
}
}

This comment has been minimized.

@liewegas

liewegas Jul 9, 2017

Member

Hmm this seems reasonable, but there is a lot of room for things to go wrong. Have you sent it through rados/monthrash yet?

This comment has been minimized.

@jecluis

jecluis Jul 10, 2017

Member

I didn't. I pushed this out just after testing it locally, and then I went afk. I'm now waiting for shaman and will then put this through teuthology.

@liewegas liewegas merged commit 382192b into ceph:master Jul 10, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment