mon/Monitor: recreate mon session if features changed #16230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joao Eduardo Luis <joao@suse.de>
Signed-off-by: Joao Eduardo Luis <joao@suse.de>
Signed-off-by: Joao Eduardo Luis <joao@suse.de>
Fixes: http://tracker.ceph.com/issues/20433 Signed-off-by: Joao Eduardo Luis <joao@suse.de>
liewegas
reviewed
Jul 9, 2017
| s->put(); | ||
| s = nullptr; | ||
| } | ||
| } |
There was a problem hiding this comment.
Hmm this seems reasonable, but there is a lot of room for things to go wrong. Have you sent it through rados/monthrash yet?
There was a problem hiding this comment.
I didn't. I pushed this out just after testing it locally, and then I went afk. I'm now waiting for shaman and will then put this through teuthology.
|
passed rados:monthrash http://pulpito.ceph.com/joao-2017-07-10_13:28:49-rados:monthrash-wip-20443-distro-basic-smithi/ (101/102 passed) http://pulpito.ceph.com/joao-2017-07-10_15:10:40-rados:monthrash-wip-20443-distro-basic-smithi/ (rerun of failed jobs, passed) |
liewegas
approved these changes
Jul 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: http://tracker.ceph.com/issues/20433
Signed-off-by: Joao Eduardo Luis <joao@suse.de>