common,mds,mgr,mon,osd: store event only if it's added #16312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
force-pushed
the
wip-store-event-if-added
branch
4 times, most recently
from
ca19d7a
to
e704073
Compare
|
This seems right. I'm scared about the number of call sites that have to change, though, and that we'll introduce something subtle. :( |
|
Hold this PR for mimic? |
|
http://pulpito.ceph.com/kchai-2017-07-13_18:13:10-rados-wip-kefu-testing-distro-basic-smithi/
|
|
i am fine either way. this fix mostly addresses the possible crashes after timer is shutdown, and this only happens when the daemon is being brought down. |
|
@jdurgin what do you think? |
|
Unless this is causing a bunch of noise in the tests, I'd prefer postponing to mimic |
|
okay, so far no noises is observed in tests caused by the problem mentioned above. let's hold this PR for mimic! |
tchaikov
force-pushed
the
wip-store-event-if-added
branch
3 times, most recently
from
f754b9c
to
2449b3a
Compare
otherwise * we will try to cancel it even it's never been added * we will keep a dangling pointer around. which is, well, scaring. * static analyzer will yell at us: Memory - illegal accesses (USE_AFTER_FREE) Signed-off-by: Kefu Chai <kchai@redhat.com>
liewegas
approved these changes
Aug 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otherwise
scaring.
Memory - illegal accesses (USE_AFTER_FREE)
Signed-off-by: Kefu Chai kchai@redhat.com