Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization for connection establishment #16414

Closed

Conversation

shangfufei
Copy link

Under the mode of RDMA communication, this modification can improve the efficiency of establishing connections and improve the success rate of connection establishment.

#16006
Signed-off-by: shangfufei shangfufei@inspur.com

Signed-off-by: shangfufei <shangfufei@inspur.com>
@shangfufei
Copy link
Author

#16006
Revert clean_up, that will be fixed later. This application will only submit other codes to optimize connect establishment.
@yuyuyu101 , please review

@tchaikov tchaikov requested a review from yuyuyu101 July 20, 2017 02:14
Copy link

@amitkumar50 amitkumar50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe comparion operator takes more assembly code+processor cycles wrt negation operation or simply
we can replace this code with if(connected).

For comparison connected has to be created bitwise on memory then 1 has to be created bitwise on memory. Then both need to compared bit-by-bit.
But for if(connected) only connected is created on memory and navigated once.

I believe 3 machine cycles are extra used for comparing with 1.

Even comparing with constants is not good for future enhancements and tracking.

@shangfufei shangfufei closed this Jul 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants