osd: add multiple objecter finishers #16521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myoungwon
force-pushed
the
wip-objecter-finishers
branch
2 times, most recently
from
2241632
to
e2b5e87
Compare
liu-chunmei
approved these changes
Jul 24, 2017
myoungwon
force-pushed
the
wip-objecter-finishers
branch
from
e2b5e87
to
66bb4d7
Compare
|
@liu-chunmei Performance improvement is less than 10 percent in my experiment environment (proxy random read 220K IOPS-> 240K IOPS). But I observed that as the load increases, a objecter finisher use more CPU (light load: 25%, heavy load: nearly 60%). So I think this would be a bottleneck if msgr-workers send/receive packets faster. |
liu-chunmei
approved these changes
Aug 3, 2017
myoungwon
force-pushed
the
wip-objecter-finishers
branch
from
66bb4d7
to
a764f90
Compare
Bluestore and Filestore already adapt multiple finishers to improve IO performance. But Objecter finisher (for tier approach) is still single thread. This can be a bottleneck if we generate many IOs as Bluestore and Filestore because most of completion processes (proxy, writeback) are handled by a objecter finisher. Signed-off-by: Myoungwon Oh <omwmw@sk.com>
|
Rebase is done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bluestore and Filestore already adapt multiple finishers to improve IO performance.
But Objecter finisher (for tier approach) is still single thread. This can be a
bottleneck if we generate many IOs as Bluestore and Filestore because most of
completion processes (proxy, writeback) are handled by a objecter finisher.
Signed-off-by: Myoungwon Oh omwmw@sk.com