Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv/RocksDBStore: extract common code to a new function #16532

Merged
merged 2 commits into from Aug 11, 2017
Merged

kv/RocksDBStore: extract common code to a new function #16532

merged 2 commits into from Aug 11, 2017

Conversation

liupan1111
Copy link
Contributor

@liupan1111 liupan1111 commented Jul 24, 2017 •
edited

  1. two set(...) functions have most of same code.
  2. submit_transaction and submit_transaction_sync has almost same code, accept "sync" option value.

@liupan1111
Copy link
Contributor Author

@liewegas please help take a look, thanks.

@liupan1111
Copy link
Contributor Author

retest this please

1 similar comment
@tchaikov
Copy link
Contributor

retest this please

Pan Liu added 2 commits August 7, 2017 22:21
kv/RocksDBStore: extract common code from set function.
6b86ca6 
Signed-off-by: Pan Liu <wanjun.lp@alibaba-inc.com>
kv/RocksDBStore: extract common code from submit_transaction function
5d5b003 
Signed-off-by: Pan Liu <wanjun.lp@alibaba-inc.com>
@liupan1111
Copy link
Contributor Author

Finished rebase, retest this please.

@liupan1111
Copy link
Contributor Author

@joscollin could you help test this? Thanks!

@joscollin
Copy link
Member

@liupan1111
I prefer not to test a PR that I don't review. It's better if the reviewer himself test the PR. I see that @liewegas has already added a needs-qa label. So it will be tested soon.

@liupan1111
Copy link
Contributor Author

@joscollin yes, reasonable to me. Thank you all the same!

@liewegas liewegas merged commit 3fd5f40 into ceph:master Aug 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liewegas liewegas liewegas approved these changes

Assignees
No one assigned
Labels
bluestore cleanup needs-qa wip-sage-testing
Projects
None yet
Milestone
No milestone
4 participants
@liupan1111 @tchaikov @joscollin @liewegas