qa: Fix shebangs on openstack scripts #16546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many of the files in qa/qa_scripts/openstack had incorrect shebang lines: the bang was missing. This means that those scripts would execute using the calling user's login shell, which is doubtless not what the author intended. Now they'll always use bash. Two scripts do not need shebangs, because they contain only library functions and don't execute anything. I removed their shebangs. Signed-off-by: Alan Somers <asomers@gmail.com>
amitkumar50
approved these changes
Jul 27, 2017
tchaikov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many of the files in qa/qa_scripts/openstack had incorrect shebang
lines: the bang was missing. This means that those scripts would
execute using the calling user's login shell, which is doubtless not
what the author intended. Now they'll always use bash.
Two scripts do not need shebangs, because they contain only library
functions and don't execute anything. I removed their shebangs.
Signed-off-by: Alan Somers asomers@gmail.com