vstart.sh: wait for mgr to be active before running cmds #16556
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we don't wait for the mgr to become active, we'll be racing when running mgr-specific commands and the monitors may not know what to do with them. Signed-off-by: Joao Eduardo Luis <joao@suse.de>
wjwithagen
reviewed
Jul 25, 2017
| break | ||
| fi | ||
| echo "Waiting for MGR to become active." | ||
| waited_for=$((`date +%s` - wait_active_start)) |
There was a problem hiding this comment.
I really do not like this construct.
In other scripts the sequence is something like
for w in \`seq 1 $timeout}\`; do .....; if oke; then break; done
And as such obvious need to work with date +%s and math
Also printing "Waiting ...." every sec is going to uselessly polute the output log
There was a problem hiding this comment.
yeah, i'll rework the patch. tbh, this was a nasty quick kludge to get my day starting ;)
|
fwiw using 'ceph tell mgr ' accomplishes the same thing. or issugin any other statically-defined mgr command (e.g., 'ceph pg stat') first so that we block for mgr startup. see #16564 |
|
I like sage's solution better. Please see #16564 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we don't wait for the mgr to become active, we'll be racing when
running mgr-specific commands and the monitors may not know what to do
with them.
Signed-off-by: Joao Eduardo Luis joao@suse.de