common: make some message informative, instead of error #16594
Conversation
|
jenkins retest this please |
1 similar comment
|
jenkins retest this please |
src/os/filestore/HashIndex.cc
Outdated
| @@ -396,7 +396,7 @@ int HashIndex::read_settings() { | |||
| if (r == -ENODATA) | |||
| return 0; | |||
| if (r < 0) { | |||
| derr << __func__ << " error reading settings: " << cpp_strerror(r) << dendl; | |||
| dout(0) << __func__ << " error reading settings: " << cpp_strerror(r) << dendl; | |||
There was a problem hiding this comment.
@wjwithagen why do you think it's not an error?
There was a problem hiding this comment.
@tchaikov
Because the program merrily continues with the default properties.
So it is no more than perhaps a strong warning
There was a problem hiding this comment.
i am not sure about this unless i understand what the error is and why it's so.
There was a problem hiding this comment.
@tchaikov
I'll try and digout the code a bit more. But all FreeBSD tests generate this warning and still run to perfect completion.
There was a problem hiding this comment.
@wjwithagen probably you could pastebin the error message?
There was a problem hiding this comment.
@tchaikov
Thanx for being persistent... Is was an error in the headers.
Perhaps still something leftover from cleaning up.
It is again a ENODATA problem ....
No compat.h included, so ENODATA has the wrong (boost) value.
Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
wjwithagen
force-pushed
the
wip-wjw-reduce-info-messages
branch
from
f2c6116
to
8241a32
Compare
|
@tchaikov |
So they should not be errors, and should not be on the CLI output
Signed-off-by: Willem Jan Withagen wjw@digiware.nl