osd: start pool IDs from 1 #16626
Closed
osd: start pool IDs from 1 #16626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CephFS doesn't like id=0 pools, which didn't used to matter because id 0 was always consumed by RBD. Now, there is no default rbd pool, so cephfs users encounter this problem. Fixes: http://tracker.ceph.com/issues/20792 Signed-off-by: John Spray <john.spray@redhat.com>
|
I could have sworn @gregsfortytwo fixed this several weeks back as part of his no-rbd-pool series... did we break something? |
|
.. when i do a vstart, i have no pools, and when i create one i get pool 1 'foo' replicated size 1 min_size 1 crush_rule 0 object_hash rjenkins pg_num 1 pgp_num 1 last_change 6 flags hashpspool stripe_width 0 |
|
Huh, yeah, I'm finding (minus patch) that my pools start from 1 too. So I am confused :-/ |
|
Still don't know what was going on, but on second look this fix seems definitely wrong, I can see the new_pool_max is pre incremented when used during pool creation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CephFS doesn't like id=0 pools, which didn't used to
matter because id 0 was always consumed by RBD. Now,
there is no default rbd pool, so cephfs users
encounter this problem.
Fixes: http://tracker.ceph.com/issues/20792
Signed-off-by: John Spray john.spray@redhat.com