use STL find() and iterators instead of count() #16630
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
reviewed
Jul 27, 2017
| @@ -443,7 +443,7 @@ int AdminSocket::register_command(std::string command, std::string cmddesc, Admi | |||
| { | |||
| int ret; | |||
| m_lock.Lock(); | |||
| if (m_hooks.count(command)) { | |||
| if (m_hooks.find(command) != m_hooks.end()) { | |||
There was a problem hiding this comment.
quote from bits/stl_map.h
size_type
count(const key_type& __x) const
{ return _M_t.find(__x) == _M_t.end() ? 0 : 1; }There was a problem hiding this comment.
* This function only makes sense for multimaps; for map the result will
* either be 0 (not present) or 1 (present).
*/
This PR is 1st part of replacement of if(container.count(foo)) with container.find(foo). Since the .count(foo) code searches for key till end and returns TRUE/FALSE, it's good to quit the search if we find the key at 1st instance. After this PR gets rolled out, similar PRs would be created for other modules as well. Resolves: http://tracker.ceph.com/issues/432 Signed-off-by: Amit Kumar amitkuma@redhat.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is 1st part of replacement of if(container.count(foo)) with container.find(foo). Since the .count(foo) code searches for key till end and returns TRUE/FALSE, it's good to quit the search if we find the key at 1st instance.
After this PR gets rolled out, similar PRs would be created for other modules as well.
Resolves: http://tracker.ceph.com/issues/432
Signed-off-by: Amit Kumar amitkuma@redhat.com