osd: handle misdirected pg command #1664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can get a query on a pg we still have but are no longer primary for. If that happens, do not reply. The client will resend to the correct OSD assuming it has the map. Send them the latest incremental so that we know they know there is something new. We don't know the exact epoch they have, unfortunately, because MCommand doesn't include it, but a newer inc is enough to make them request the right incrementals from a mon. Eventually they will figure it out and Objecter will resend the request to the correct target. It is possible we should include epoch in the MCommand message so that we can do this mapping "correctly" (as in, the same way MOSDOp does). That makes MCommand less general, though... a PG-specific command message might be the most precise thing. Another day... Fixes: #8085 Signed-off-by: Sage Weil <sage@inktank.com>
athanatos
pushed a commit
that referenced
this pull request
Apr 14, 2014
osd: handle misdirected pg command Reviewed-by: Samuel Just <sam.just@inktank.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we get this message after we lose primary-ship, we call into a helper
method that asserts. We shouldn't do anythign if we're no longer primary,
and need to poke the client to be sure they know to resend elsewhere.