osd: exit(1) directly without lock if init fails #16647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please. |
xiexingguo
approved these changes
Jul 28, 2017
tchaikov
force-pushed
the
wip-osd-exit-directly-on-failure
branch
from
f04edce
to
164fd5f
Compare
if init fails to connect to a monitor, we just exit(1), there is no need to set the `r` or lock the grand osd_lock for this. this change also silences the warning of clang analyzer: Value stored to 'r' is never read Signed-off-by: Kefu Chai <kchai@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if init fails to connect to a monitor, we just exit(1), there is no need
to set the
ror lock the grand osd_lock for this. this change alsosilences the warning of clang analyzer:
Value stored to 'r' is never read
Signed-off-by: Kefu Chai kchai@redhat.com