Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osdc, class_api: kill implicit string conversions #16648

Merged
merged 2 commits into from Aug 10, 2017

Conversation

Projects
None yet
4 participants
@branch-predictor
Copy link
Contributor

commented Jul 28, 2017

This gets rid of implicit c-string to std::string conversions, as they are expensive and unnecessary anyway.

Signed-off-by: Piotr Dałek piotr.dalek@corp.ovh.com

branch-predictor added some commits Jul 28, 2017

osdc/Objecter: kill implicit string conversion
This gets rid of implicit c-string to std::string conversions, as
they are expensive and unnecessary anyway.

Signed-off-by: Piotr Dałek <piotr.dalek@corp.ovh.com>
class_api.cc: kill implicit string conversion
This gets rid of implicit c-string to std::string conversions, as
they are expensive and unnecessary anyway.

Signed-off-by: Piotr Dałek <piotr.dalek@corp.ovh.com>
@gregsfortytwo
Copy link
Member

left a comment

Reviewed-by: Greg Farnum gfarnum@redhat.com

@liewegas liewegas merged commit d5c09a9 into ceph:master Aug 10, 2017

3 of 4 checks passed

make check (arm64) make check failed
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@branch-predictor branch-predictor deleted the ovh:bp-kill-str-conv branch Aug 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.