mgr: apply a threshold to perf counter prios #16699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
reviewed
Jul 31, 2017
src/messages/MMgrConfigure.h
Outdated
| static const int COMPAT_VERSION = 1; | ||
|
|
||
| public: | ||
| uint32_t stats_period; | ||
| uint32_t stats_threshold; |
There was a problem hiding this comment.
maybe assign a safe default value to it here?
tchaikov
reviewed
Jul 31, 2017
src/mgr/MgrClient.cc
Outdated
| @@ -227,9 +227,17 @@ void MgrClient::send_report() | |||
| pcc->with_counters([this, report]( | |||
| const PerfCountersCollection::CounterMap &by_path) | |||
| { | |||
| auto include_counter = [this](const PerfCounters::perf_counter_data_any_d &ctr){ | |||
| if (ctr.prio >= (int)stats_threshold) { | |||
There was a problem hiding this comment.
nit, just
return ctr.prio >= (int)stats_threshold;
|
echo kefu's nits, otherwise lgtm! |
jcsp
force-pushed
the
wip-mgr-perf-threshold
branch
from
4414b2c
to
5bc484d
Compare
added 2 commits
August 31, 2017 12:16
...so that we can control the level of load we're putting on ceph-mgr with perf counters. Don't collect anything below PRIO_USEFUL by default. Signed-off-by: John Spray <john.spray@redhat.com>
ceph-mgr has missed out on the `config set` command that the other daemons got recently: add it here and hook it all up to the stats period and threshold settings. Signed-off-by: John Spray <john.spray@redhat.com>
jcsp
force-pushed
the
wip-mgr-perf-threshold
branch
from
5bc484d
to
057b73d
Compare
|
Fixed the nits and added runtime updates to the config (realised mgr never got the |
|
might want to have a simple test in |
tchaikov
approved these changes
Sep 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...so that we can control the level of load
we're putting on ceph-mgr with perf counters. Don't collect
anything below PRIO_USEFUL by default.
Signed-off-by: John Spray john.spray@redhat.com