Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: pg: be more careful with locking around forced pg recovery #16712

Merged
merged 1 commit into from Aug 1, 2017

Commits on Aug 1, 2017

  1. osd: pg: be more careful with locking around forced pg recovery

    This does several little things that add up to big concurrency and safety
    improvements:
    * Switch to passing around PGRefs instead of raw pointers, which is
      generally a good idea
    * drop the pg_map_lock once we're done looking up the PGRefs, since
      we don't need it and holding the PG pointer alive was the only previous
      thing that might have made it necessary
    * don't hold the recovery_lock since we don't need any OSD-level
      synchronization
    * make sure the PG is not being deleted before we do a force-change of its
      state
    
    Fixes: http://tracker.ceph.com/issues/20808
    
    Signed-off-by: Greg Farnum <gfarnum@redhat.com>
    gregsfortytwo committed Aug 1, 2017
    Copy the full SHA
    f19a3d9 View commit details
    Browse the repository at this point in the history