Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ppc64 support for ceph #16753

Merged
merged 1 commit into from Aug 14, 2017
Merged

Fix ppc64 support for ceph #16753

merged 1 commit into from Aug 14, 2017

Conversation

b-ranto
Copy link
Contributor

@b-ranto b-ranto commented Aug 2, 2017

The ppc64 support requires a couple of changes:

  • adding the ppc64 support to cmake
  • changing optimized crc32 code to compile on ppc64le only (the asm code is ppc64le)
  • moving ifdef condition before crc32_align to avoid defined but not used warning (it is not used anywhere else)

Signed-off-by: Boris Ranto branto@redhat.com

I was able to do a ppc64 build in fedora rawhide with this patch.

@b-ranto b-ranto force-pushed the wip-fix-ppc64 branch 2 times, most recently from cf36228 to 76657dc Compare August 3, 2017 08:22
The ppc64 support requires a couple of changes:
- adding the ppc64 support to cmake
- changing optimized crc32 code to compile on ppc64le only
- moving ifdef condition before crc32_align to avoid defined but not
used warning

Signed-off-by: Boris Ranto <branto@redhat.com>
Copy link
Contributor

@tchaikov tchaikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as long as shaman builders are happy

@b-ranto
Copy link
Contributor Author

b-ranto commented Aug 14, 2017

Jenkins built the packages without any issues:

https://jenkins.ceph.com/job/ceph-dev/11132/

@b-ranto b-ranto merged commit 7047301 into master Aug 14, 2017
@b-ranto b-ranto deleted the wip-fix-ppc64 branch August 14, 2017 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants