Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard: fix pool size base conversion #16771

Merged
merged 3 commits into from Aug 29, 2017
Merged

Conversation

yanyixing
Copy link
Contributor

Signed-off-by: Yixing Yan yanyx@umcloud.com
the origin is as blew
image

image
The pool size is not same as ceph df

After using the dimless_binary function, the pool size is correct.
image

@gmayyyha
Copy link
Contributor

gmayyyha commented Aug 3, 2017

@yanyixing filesystems pools have same issue.
qq20170803-141537

@yanyixing
Copy link
Contributor Author

@gmayyyha fixed

@yanyixing
Copy link
Contributor Author

Jenkins retest this please

@yanyixing yanyixing changed the title dashboard: fix pool size base conversion pybind: fix pool size base conversion Aug 3, 2017
@yanyixing
Copy link
Contributor Author

Jenkins retest this please

2 similar comments
@yanyixing
Copy link
Contributor Author

Jenkins retest this please

@yanyixing
Copy link
Contributor Author

Jenkins retest this please

@yanyixing
Copy link
Contributor Author

@jcsp please review

@tchaikov
Copy link
Contributor

@yanyixing please fix your "Signed-off-by" line in your commit messages? so it looks like

Signed-off-by: Yixing Yan <yanyx@umcloud.com>

@tchaikov tchaikov changed the title pybind: fix pool size base conversion mgr/dashboard: fix pool size base conversion Aug 29, 2017
Copy link
Contributor

@tchaikov tchaikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm modulo the signed-off-by lines.

Signed-off-by: Yixing Yan <yanyx@umcloud.com>
Signed-off-by: Yixing Yan <yanyx@umcloud.com>
Signed-off-by: Yixing Yan <yanyx@umcloud.com>
@yanyixing
Copy link
Contributor Author

@tchaikov correct the commit message

@tchaikov tchaikov requested a review from jcsp August 29, 2017 11:13
@jcsp jcsp added the mgr label Aug 29, 2017
@liewegas liewegas merged commit 3947f91 into ceph:master Aug 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants