pybind: fix block's pool sub menu #16774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanyixing
changed the title
yanyixing
changed the title
yanyixing
changed the title
|
Jenkins retest this please |
Signed-off-by: Yixing Yan yanyx@umcloud.com
yanyixing
changed the title
|
Jenkins retest this please |
1 similar comment
|
Jenkins retest this please |
|
@jcsp please review |
tchaikov
approved these changes
Aug 29, 2017
|
weird, i cannot collapse the "Pools" treeview by clicking the "Pools" item after the treeview is active. |
|
@tchaikov my commit message is not correct, is there a way to correct it? |
|
@yanyixing which commit message? if it's 4e1d539, then we cannot change it anymore, as it's been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yixing Yan yanyx@umcloud.com
If there is no rbd_pool, the block's pool sub menu should have a "None found" item, but the item belong with the block menu .
Fixed as blew: