mds: miscellaneous snap fixes #16778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ukernel
changed the title
ukernel
force-pushed
the
wip-mds-snap-misc
branch
2 times, most recently
from
35670ee
to
d6d000b
Compare
|
submodules for project are unmodified |
amitkumar50
suggested changes
Aug 15, 2017
| CInode *in = head_in; | ||
| if (follows > 0) { | ||
| in = mdcache->pick_inode_snap(head_in, follows); | ||
| // intermediate snap inodes |
There was a problem hiding this comment.
@ukernel Thanks for PR
I believe It would be even better if we start comment with capital letter something as:
// Intermediate snap inodes
Also I believe there is no such use of leaving space between // and Intermediate
There was a problem hiding this comment.
if you check the code, almost all comments start with space
| << " wrlock lock " << *lock << " on " << *oldin << dendl; | ||
| if (!in->client_caps.empty()) { | ||
| const set<snapid_t>& snaps = in->find_snaprealm()->get_snaps(); | ||
| // clone caps? |
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
Current mds track both head inodes and snap inodes through unsorted map. The unsorted map makes finding snap inode that follows a given snapid difficult. Currnt MDCache::pick_inode_snap() use snap set to guess snap inode's last. The method isn't reliable because snap set may change after creating the snap inode. For example: MDS cows inode[2,head] with snap set[5,6], which results inode[2,6] and inode[7,head]. Later mds wants to find snap inode that follows snapid 2. But the snap set become [5], mds can't find snap inode [2,5]. Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
previous commit 4b95fbe "mds: properly do null snapflush part2" isn't complete. It doesn't properly handle case that snap get deleted before receiving corresponding snapflush. Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
ukernel
changed the title
ukernel
force-pushed
the
wip-mds-snap-misc
branch
from
d6d000b
to
0e435e2
Compare
These flags tell mds if there is pending capsnap explictly. Without this explict notification, mds can only conclude if client has pending capsnap. The method mds use is inefficient and error-prone. Fixes: http://tracker.ceph.com/issues/20752 Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
ukernel
force-pushed
the
wip-mds-snap-misc
branch
from
0e435e2
to
ecde54f
Compare
batrick
approved these changes
Aug 29, 2017
previous commit "mds: track snap inodes through sorted map" makes MDCache::dump_cache return 1 on success. Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
ukernel
force-pushed
the
wip-mds-snap-misc
branch
from
ba166e4
to
f519fca
Compare
batrick
added a commit
that referenced
this pull request
Sep 7, 2017
* refs/remotes/upstream/pull/16778/head: mds: fix return value of MDCache::dump_cache mds: new cap message flags indicate if there is pending capsnap mds: properly do null snapflush part2 mds: track snap inodes through sorted map mds: properly drop wrlock when finishing snapflush Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.