messages: initialize variable tid in MMDSFindIno #16793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joscollin
requested changes
Aug 4, 2017
src/messages/MMDSFindIno.h
Outdated
| @@ -22,7 +22,7 @@ struct MMDSFindIno : public Message { | |||
| ceph_tid_t tid; | |||
| inodeno_t ino; | |||
|
|
|||
There was a problem hiding this comment.
I would initialize them here (guaranteed), which can be overridden by the initializer list if needed.
|
Jenkins restest this please |
|
@joscollin Thanks for comments. Done Changes. |
joscollin
requested changes
Aug 5, 2017
src/messages/MMDSFindIno.h
Outdated
| ceph_tid_t tid; | ||
| inodeno_t ino; | ||
| ceph_tid_t tid = 0; | ||
| inodeno_t ino = {0}; | ||
|
|
There was a problem hiding this comment.
nit: There is no need of = if you do it this way {0}. Change both lines to same method of initialization.
|
@joscollin Thanks for Comments. Done changes. |
joscollin
requested changes
Aug 6, 2017
src/messages/MMDSFindIno.h
Outdated
| ceph_tid_t tid; | ||
| inodeno_t ino; | ||
| ceph_tid_t tid {0}; | ||
| inodeno_t ino {0}; | ||
|
|
There was a problem hiding this comment.
There is no need of initializing ino. See the definition of inodeno_t. By default it is initialized to 0 in the constructor.
|
@joscollin Done changes. Thanks for comments. |
joscollin
approved these changes
Aug 7, 2017
Fixes the coverity Issue: ** 717286 Uninitialized scalar field CID 717286 (ceph#1 of 1): Uninitialized scalar field (UNINIT_CTOR) 2. uninit_member: Non-static class member tid is not initialized in this constructor nor in any functions that it calls. Signed-off-by: Amit Kumar amitkuma@redhat.com
joscollin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the coverity Issue:
Signed-off-by: Amit Kumar amitkuma@redhat.com