Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

radosgw: usage: fix bytes_sent bug. #16834

Merged
merged 2 commits into from Aug 9, 2017
Merged

Commits on Aug 9, 2017

  1. Fix bytes_sent bugs.

    log bytes sent/received.
    add cct to bufferingfilter
    add cct to RGWRestfulIO
    AccountingFilter - save cct for debugging output
    implement AccountingFilter::complete_request() - account for bytes reported here.
    BufferingFilter<T>::complete_request() - ignore counts from send_content_length() complete_header();
    
    Code quality note:
    this patch makes "cct" available for a lot of newly added debug
    statements.  The debug statements are mostly not very useful (and should
    go away in the future) - *But* the "cct" logic should be redone and
    incorporated into some base class (such RestfulClient) so that it is
    possible to easily add in debug statements such as these in the future.
    
    Fixes: http://tracker.ceph.com/issues/19870
    Signed-off-by: Marcus Watts <mwatts@redhat.com>
    mdw-at-linuxbox committed Aug 9, 2017
    Copy the full SHA
    0172aab View commit details
    Browse the repository at this point in the history
  2. Test bytes_sent bugs.

    Rearrange logic to make it easier to measure accumulation.
    Instrument the boto request/response loop to count bytes in and out.
    Accumulate byte counts in usage like structure.
    Compare actual usage reported by ceph against local usage measured.
    Report and assert if there are any short-comings.
    Remove zone placement rule that was newly added at end: tests should be rerunable.
    
    Nit: the logic to wait for "delete_obj" is not quite right.
    
    Fixes: http://tracker.ceph.com/issues/19870
    Signed-off-by: Marcus Watts <mwatts@redhat.com>
    mdw-at-linuxbox committed Aug 9, 2017
    Copy the full SHA
    a45ab45 View commit details
    Browse the repository at this point in the history