crush: more class fixes #16837
Merged
crush: more class fixes #16837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will prevent the current crush rule from referencing a non-existent shadow tree and hence avoid a coredump such as below: 0> 2017-08-05 09:54:19.943349 7f73887d6700 -1 /clove/vm/xxg/rpm/ceph/rpmbuild/BUILD/ceph-12.1.2.1/src/crush/CrushWrapper.cc: In function 'int CrushWrapper::get_rule_weight_osd_map(unsigned int, std::map<int, float>*)' thread 7f73887d6700 time 2017-08-05 09:54:19.941291 /clove/vm/xxg/rpm/ceph/rpmbuild/BUILD/ceph-12.1.2.1/src/crush/CrushWrapper.cc: 1631: FAILED assert(b) ceph version 12.1.2.1-11-gd0f812a (d0f812a3a757b319c26794f558b57770663ab324) luminous (rc) 1: (ceph::__ceph_assert_fail(char const*, char const*, int, char const*)+0x110) [0x7f7398b66ea0] 2: (CrushWrapper::get_rule_weight_osd_map(unsigned int, std::map<int, float, std::less<int>, std::allocator<std::pair<int const, float> > >*)+0x54e) [0x7f7398daac4e] 3: (PGMap::get_rule_avail(OSDMap const&, int) const+0x68) [0x7f73989a6428] 4: (PGMap::get_rules_avail(OSDMap const&, std::map<int, long, std::less<int>, std::allocator<std::pair<int const, long> > >*) const+0x35c) [0x7f73989b748c] 5: (PGMap::encode_digest(OSDMap const&, ceph::buffer::list&, unsigned long) const+0x16) [0x7f73989b7506] 6: (DaemonServer::send_report()+0x2a4) [0x7f73989f5474] 7: (DaemonServer::maybe_ready(int)+0x2f9) [0x7f73989f6129] 8: (DaemonServer::ms_dispatch(Message*)+0xce) [0x7f73989ff68e] 9: (DispatchQueue::entry()+0x792) [0x7f7398dd2a22] 10: (DispatchQueue::DispatchThread::entry()+0xd) [0x7f7398c1429d] 11: (()+0x7df3) [0x7f739640cdf3] 12: (clone()+0x6d) [0x7f73954f23ed] Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
xiexingguo
force-pushed
the
wip-still-more-class-fixes
branch
from
2c8f2de
to
87952fc
Compare
The current version is broken. E.g., it should only remove a class which is never referenced by any device. Since we now create new classes automatically, we shall automatically recycle dead classes too. So this command is definitely unuseful. (Actually it is weird that we keep 'class rm' without keeping the corresponding 'class create' command). Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
If a class is no more referenced by any devices or crush rules, it shall be considered as dead. This patch makes Ceph automatically recycles those dead classes, so user does not to explicitly call 'class rm', which is unsafe and annoying. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
liewegas
approved these changes
Aug 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch set fixes a coredump and some other potential problems..