rados: Intializing members class StriperTest #16843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the coverity issue: ** 1221538 Uninitialized pointer field 2. uninit_member: Non-static class member cluster is not initialized in this constructor nor in any functions that it calls. 4. uninit_member: Non-static class member ioctx is not initialized in this constructor nor in any functions that it calls. CID 1221538 (ceph#1 of 1): Uninitialized pointer field (UNINIT_CTOR) 6. uninit_member: Non-static class member striper is not initialized in this constructor nor in any functions that it calls Signed-off-by: Amit Kumar amitkuma@redhat.com
|
jenkins test this please |
|
This is actually failing a CLI test (on src/test/cli/crushtool/build.t) but I haven't seen it fail on other PRs. Can you rebase? |
|
Jenkins retest this please |
|
@gregsfortytwo |
|
@amitkumar50 Do a rebase |
|
retest this please |
liewegas
approved these changes
Sep 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the coverity issue:
** 1221538 Uninitialized pointer field
Signed-off-by: Amit Kumar amitkuma@redhat.com