rgw: fix opslog can't record referrer when using curl as client #16863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikulely
changed the title
mikulely
force-pushed
the
fix-curl-referer
branch
3 times, most recently
from
975e5dd
to
dda244d
Compare
|
@joscollin mind to take a look? Thx. |
joscollin
changed the title
joscollin
requested changes
Aug 8, 2017
| @@ -346,7 +346,11 @@ int rgw_log_op(RGWRados *store, RGWREST* const rest, struct req_state *s, | |||
| else | |||
| set_param_str(s, "REMOTE_ADDR", entry.remote_addr); | |||
| set_param_str(s, "HTTP_USER_AGENT", entry.user_agent); | |||
| set_param_str(s, "HTTP_REFERRER", entry.referrer); | |||
There was a problem hiding this comment.
I think this can be fixed as HTTP_REFERER for now and do the entire misspelling clean up as a different PR. Because after we fix the misspelling, the below logic won't be needed at all. What do you say ?
There was a problem hiding this comment.
As AWS S3 are using referrer (see http://docs.aws.amazon.com/AmazonS3/latest/dev/LogFormat.html Referrer Section), rgw are correctly following this convention, but curl -e option are still using misspelling referer . I think it's a problem of legacy client, this purpose of this pr is to improve the rgw compatibility.
mikulely
force-pushed
the
fix-curl-referer
branch
from
dda244d
to
4479a1e
Compare
Fixes: http://tracker.ceph.com/issues/20935 Reported-by: Zhang Shaowen <zhangshaowen@cmss.chinamobile.com> Signed-off-by: Jiaying Ren <jiaying.ren@umcloud.com>
mikulely
force-pushed
the
fix-curl-referer
branch
from
4479a1e
to
23323b7
Compare
|
Jenkins, retest this please. |
1 similar comment
|
Jenkins, retest this please. |
|
Jenkins retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: http://tracker.ceph.com/issues/20935
Signed-off-by: Jiaying Ren jiaying.ren@umcloud.com