mon: fix wrong mon-num counting logic of 'ceph features' command #16887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiexingguo
force-pushed
the
wip-mon-count
branch
from
b8883e1
to
3eb45d5
Compare
Monitors need to talk to each other, which causes the inaccurate
mon-num counting logic of 'ceph features' command.
E.g.:
(1) By specifying 2 monitors, you get 4 from 'ceph features':
"mon": {
"group": {
"features": 2305244844532236283,
"release": "luminous",
"num": 4
}
},
(2) By specifying 3 monitors, you get 9 from 'ceph features':
"mon": {
"group": {
"features": 2305244844532236283,
"release": "luminous",
"num": 9
}
},
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
xiexingguo
force-pushed
the
wip-mon-count
branch
from
3eb45d5
to
b68f31a
Compare
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
liewegas
approved these changes
Aug 8, 2017
tchaikov
pushed a commit
to tchaikov/ceph
that referenced
this pull request
Mar 28, 2018
The issue which resulted in too large v2 image ids was fixed under ceph#16887. Fixes: http://tracker.ceph.com/issues/17310 Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 61734d2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.