messages: Initialization of member variables #16898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins retest this please |
gregsfortytwo
requested changes
Aug 9, 2017
src/messages/MExportDirDiscover.h
Outdated
| @@ -19,7 +19,7 @@ | |||
| #include "include/types.h" | |||
|
|
|||
| class MExportDirDiscover : public Message { | |||
| mds_rank_t from; | |||
| mds_rank_t from = 0; | |||
There was a problem hiding this comment.
0 has a meaning here, how about -1.
src/messages/MDirUpdate.h
Outdated
| @@ -19,10 +19,10 @@ | |||
| #include "msg/Message.h" | |||
|
|
|||
| class MDirUpdate : public Message { | |||
| mds_rank_t from_mds; | |||
| mds_rank_t from_mds = 0; | |||
src/messages/MDirUpdate.h
Outdated
| int32_t dir_rep; | ||
| int32_t discover; | ||
| int32_t dir_rep = 0; | ||
| int32_t discover = 0; |
There was a problem hiding this comment.
This is default-initialized to 5 below, maybe do that instead?
src/messages/MDiscover.h
Outdated
| @@ -29,8 +29,8 @@ class MDiscover : public Message { | |||
| snapid_t snapid; | |||
| filepath want; // ... [/]need/this/stuff | |||
|
|
|||
| bool want_base_dir; | |||
| bool want_xlocked; | |||
| bool want_base_dir = false; | |||
There was a problem hiding this comment.
Defaults to true in the constructor; let's make them match.
amitkumar50
force-pushed
the
cov-messages-6
branch
2 times, most recently
from
aea509c
to
406348f
Compare
|
@gregsfortytwo Thanks for Comments, Review. Done Changes.. |
Fixes the coverity issues: ** 717271 Uninitialized scalar field 2. uninit_member: Non-static class member from_mds is not initialized in this constructor nor in any functions that it calls. 4. uninit_member: Non-static class member dir_rep is not initialized in this constructor nor in any functions that it calls. CID 717271 (ceph#1 of 1): Uninitialized scalar field (UNINIT_CTOR) 6. uninit_member: Non-static class member discover is not initialized in this constructor nor in any functions that it calls. ** 717272 Uninitialized scalar field 2. uninit_member: Non-static class member want_base_dir is not initialized in this constructor nor in any functions that it calls. CID 717272 (ceph#1 of 1): Uninitialized scalar field (UNINIT_CTOR) 4. uninit_member: Non-static class member want_xlocked is not initialized in this constructor nor in any functions that it calls. ** 717274 Uninitialized scalar field 2. uninit_member: Non-static class member wanted_base_dir is not initialized in this constructor nor in any functions that it calls. 4. uninit_member: Non-static class member wanted_xlocked is not initialized in this constructor nor in any functions that it calls. 6. uninit_member: Non-static class member flag_error_dn is not initialized in this constructor nor in any functions that it calls. 8. uninit_member: Non-static class member flag_error_dir is not initialized in this constructor nor in any functions that it calls. 10. uninit_member: Non-static class member unsolicited is not initialized in this constructor nor in any functions that it calls. 12. uninit_member: Non-static class member dir_auth_hint is not initialized in this constructor nor in any functions that it calls. CID 717274 (ceph#1 of 1): Uninitialized scalar field (UNINIT_CTOR) 14. uninit_member: Non-static class member starts_with is not initialized in this constructor nor in any functions that it calls. ** 717275 Uninitialized scalar field CID 717275 (ceph#1 of 1): Uninitialized scalar field (UNINIT_CTOR) 2. uninit_member: Non-static class member from is not initialized in this constructor nor in any functions that it calls. Signed-off-by: Amit Kumar amitkuma@redhat.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the coverity issues:
** 717271 Uninitialized scalar field
** 717272 Uninitialized scalar field
** 717274 Uninitialized scalar field
** 717275 Uninitialized scalar field
Signed-off-by: Amit Kumar amitkuma@redhat.com