Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os/bluestore: switch default allocator to stupid; test both bitmap and stupid in qa #16906

Merged
merged 4 commits into from Aug 12, 2017
Merged

os/bluestore: switch default allocator to stupid; test both bitmap and stupid in qa #16906

merged 4 commits into from Aug 12, 2017

Conversation

liewegas
Copy link
Member

@liewegas liewegas commented Aug 8, 2017

No description provided.

@liewegas
os/bluestore: default to bluestore_allocator = stupid
3750cf9 
Performance looks better, and code is simpler.

Also fix config option annotations.

Signed-off-by: Sage Weil <sage@redhat.com>
@liewegas
qa/objectstore/bluestore-bitmap: test bluestore bitmap allocator too
ec60fac 
Signed-off-by: Sage Weil <sage@redhat.com>
@liewegas liewegas requested a review from markhpc August 8, 2017 19:53
@liewegas
os/bluestore: default 'bluefs_allocator = stupid'
2b6eea8 
Signed-off-by: Sage Weil <sage@redhat.com>
@liewegas
os/bluestore: put StupidAllocator btree into bluestore_alloc mempool
6f189d8 
Signed-off-by: Sage Weil <sage@redhat.com>
@varadakari
Copy link
Contributor

@liewegas is this getting into Luminous or post Luminous?

@liewegas
Copy link
Member Author

liewegas commented Aug 11, 2017 via email

@liewegas
Copy link
Member Author

http://pulpito.ceph.com/sage-2017-08-10_19:22:47-rados-wip-sage-testing-20170810a-distro-basic-smithi/

@liewegas liewegas requested a review from dillaman August 11, 2017 13:31
@liewegas liewegas requested review from xiexingguo and removed request for dillaman August 11, 2017 13:31
xiexingguo
xiexingguo approved these changes Aug 12, 2017
View reviewed changes
Copy link
Member

@xiexingguo xiexingguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, our local test also shows stupid is a better choice for performance, especially for large sequential read/writes.

@liewegas liewegas merged commit 196e7f3 into ceph:master Aug 12, 2017
@liewegas liewegas deleted the wip-bluestore-stupid branch August 12, 2017 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiexingguo xiexingguo xiexingguo approved these changes

@markhpc markhpc Awaiting requested review from markhpc

Assignees
No one assigned
Labels
bluestore core needs-review
Projects
None yet
Milestone
No milestone
3 participants
@liewegas @varadakari @xiexingguo