os/bluestore: fail early on very large objects #16924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiexingguo
reviewed
Aug 9, 2017
src/os/bluestore/BlueStore.cc
Outdated
| CollectionRef& c, | ||
| OnodeRef& o, | ||
| uint64_t offset) | ||
| { | ||
| dout(15) << __func__ << " " << c->cid << " " << o->oid | ||
| << " 0x" << std::hex << offset << std::dec | ||
| << dendl; | ||
| _do_truncate(txc, c, o, offset); | ||
| int r = 0; | ||
| if (offset + length >= OBJECT_MAX_SIZE) { |
There was a problem hiding this comment.
Do you mean if (offset >= OBJECT_MAX_SIZE)
We have a hard 4GB object size limit (although in practice we want to be *well* below that!). See http://tracker.ceph.com/issues/20923 Signed-off-by: Sage Weil <sage@redhat.com>
xiexingguo
approved these changes
Aug 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a hard 4GB object size limit (although in practice we want
to be well below that!).
See http://tracker.ceph.com/issues/20923
Signed-off-by: Sage Weil sage@redhat.com