Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: Initialize member variables in rgw_sync.h, rgw_rados.h #16929

Merged
merged 1 commit into from May 3, 2019

Conversation

amitkumar50
Copy link

Fixes the coverity issues:

** 1355581 Uninitialized scalar field

CID 1355581 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member cur_shard is not initialized in
this constructor nor in any functions that it calls.

** 1356907 Uninitialized scalar field

  1. uninit_member: Non-static class member field mtime.tv_sec is not initialized
    in this constructor nor in any functions that it calls.
    CID 1356907 (FreeBSD support. #1 of 1): Uninitialized scalar field (UNINIT_CTOR)
  2. uninit_member: Non-static class member field mtime.tv_nsec is not initialized
    in this constructor nor in any functions that it calls

Signed-off-by: Amit Kumar amitkuma@redhat.com

Fixes the coverity issues:

** 1355581 Uninitialized scalar field
CID 1355581 (ceph#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member cur_shard is not initialized in
this constructor nor in any functions that it calls.

** 1356907 Uninitialized scalar field
2. uninit_member: Non-static class member field mtime.tv_sec is not initialized
in this constructor nor in any functions that it calls.
CID 1356907 (ceph#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
4. uninit_member: Non-static class member field mtime.tv_nsec is not initialized
in this constructor nor in any functions that it calls

Signed-off-by: Amit Kumar amitkuma@redhat.com
@joscollin joscollin self-requested a review August 9, 2017 10:57
@joscollin joscollin changed the title rgw: Initialization of members rgw_sync, rgw_rados rgw: Initialize member variables in rgw_sync.h, rgw_rados.h Aug 9, 2017
@joscollin joscollin removed their request for review August 10, 2017 08:13
@stale
Copy link

stale bot commented Oct 18, 2018

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you are a maintainer or core committer, please follow-up on this issue to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@stale stale bot added the stale label Oct 18, 2018
@mattbenjamin mattbenjamin self-requested a review November 1, 2018 15:33
@mattbenjamin mattbenjamin self-assigned this Nov 1, 2018
@stale stale bot removed the stale label Nov 1, 2018
@mattbenjamin mattbenjamin assigned cbodley and unassigned mattbenjamin Nov 1, 2018
Copy link
Contributor

@mattbenjamin mattbenjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this still applies, seems harmless; coverity

@stale
Copy link

stale bot commented Dec 31, 2018

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you are a maintainer or core committer, please follow-up on this issue to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@stale stale bot added the stale label Dec 31, 2018
@cbodley cbodley removed the stale label Jan 2, 2019
@cbodley
Copy link
Contributor

cbodley commented Jan 2, 2019

jenkins build docs

@stale
Copy link

stale bot commented Mar 3, 2019

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you are a maintainer or core committer, please follow-up on this issue to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@stale stale bot added the stale label Mar 3, 2019
@tchaikov
Copy link
Contributor

tchaikov commented Mar 4, 2019

might want to merge this after nautilus.

@stale stale bot removed the stale label Mar 4, 2019
@stale
Copy link

stale bot commented May 3, 2019

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@stale stale bot added the stale label May 3, 2019
@tchaikov tchaikov merged commit dfdb1d0 into ceph:master May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants