mgr: add missing call to pick_addresses #16940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this was presumably simply not applying the public_network setting at all. Fixes: http://tracker.ceph.com/issues/20955 Signed-off-by: John Spray <john.spray@redhat.com>
amitkumar50
suggested changes
Aug 14, 2017
| @@ -52,6 +53,8 @@ int main(int argc, const char **argv) | |||
| usage(); | |||
| } | |||
|
|
|||
| pick_addresses(g_ceph_context, CEPH_PICK_ADDRESS_PUBLIC); | |||
|
|
|||
There was a problem hiding this comment.
I believe a space is added Intentionally between function calls.
It is required, serves a purpose?
There was a problem hiding this comment.
I think the space is fine.
amitkumar50
approved these changes
Aug 15, 2017
| @@ -52,6 +53,8 @@ int main(int argc, const char **argv) | |||
| usage(); | |||
| } | |||
|
|
|||
| pick_addresses(g_ceph_context, CEPH_PICK_ADDRESS_PUBLIC); | |||
|
|
|||
amitkumar50
approved these changes
Aug 15, 2017
| @@ -52,6 +53,8 @@ int main(int argc, const char **argv) | |||
| usage(); | |||
| } | |||
|
|
|||
| pick_addresses(g_ceph_context, CEPH_PICK_ADDRESS_PUBLIC); | |||
|
|
|||
tchaikov
approved these changes
Aug 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this was presumably simply not
applying the public_network setting at all.
Fixes: http://tracker.ceph.com/issues/20955
Signed-off-by: John Spray john.spray@redhat.com