bluestore: fixed compilation error when enable spdk with gcc 4.8.5 #16945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pan Liu <wanjun.lp@alibaba-inc.com> Signed-off-by: Ziye Yang <optimistyzy@gmail.com>
|
@yuyuyu101 Please help take a look. It is no problem after local test. |
|
retest this please |
|
@yuyuyu101 The failure in "make check" is caused by Jenkins, not related to this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change is induced by my commit #12672.
At that time, "add_compile_options" is needed to fix compile error.
But since we've updated spdk to 17.07 and related spdk/dpdk.git, add_compile_options is no longer needed.
If we leave it in CMakelists.txt, "add_compile_options" can not be identified by low gcc version, and the developer has to upgrade gcc to 6.X.X.
By this reason, I revert this change.
Signed-off-by: Pan Liu wanjun.lp@alibaba-inc.com
Signed-off-by: Ziye Yang optimistyzy@gmail.com