Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix and enable test_pidfile.sh #16987

Merged
merged 1 commit into from Aug 15, 2017
Merged

Conversation

dzafman
Copy link
Contributor

@dzafman dzafman commented Aug 11, 2017

Increase delay so daemonized process can make progress and write/lock pidfile
Add --log_flush_on_exit to ensure log gets flushed for TEST_without_pidfile test

Fixes: http://tracker.ceph.com/issues/20770

Increase delay so daemonized process can make progress and write/lock pidfile
Add --log_flush_on_exit to ensure log gets flushed for TEST_without_pidfile test

Fixes: http://tracker.ceph.com/issues/20770

Signed-off-by: David Zafman <dzafman@redhat.com>
@dzafman dzafman changed the title test: Fix and enable test_pidfile.sh DNM: test: Fix and enable test_pidfile.sh Aug 11, 2017
@dzafman
Copy link
Contributor Author

dzafman commented Aug 11, 2017

retest this please

1 similar comment
@dzafman
Copy link
Contributor Author

dzafman commented Aug 11, 2017

retest this please

@dzafman dzafman changed the title DNM: test: Fix and enable test_pidfile.sh test: Fix and enable test_pidfile.sh Aug 11, 2017
@dzafman dzafman removed the needs-qa label Aug 11, 2017
@dzafman
Copy link
Contributor Author

dzafman commented Aug 11, 2017

make check passed twice and the 3rd is running now.

@dzafman dzafman requested a review from liewegas August 11, 2017 23:35
@dzafman
Copy link
Contributor Author

dzafman commented Aug 12, 2017

retest this please

Only failure unrelated to this change: test_objectstore_memstore.sh ............***Timeout 3600.01 sec

@dzafman dzafman requested review from a user and gregsfortytwo August 14, 2017 19:19
@dzafman dzafman merged commit 21d9337 into ceph:master Aug 15, 2017
@dzafman dzafman deleted the wip-pidfile branch August 15, 2017 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant