os/bluestore: fix clone dirty_range again #16994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we are cloning a blob for a 1 byte logical extent then dirty_range_begin will equal _end and we won't dirty the source onode (with possibly newly shared blobs). Fix by using a separate flag to indicate whether we are dirtying instead of overloading the begin/end markers for this. Note that even if they are equal dirty_range will still dirty the shard in question. This is a result of 0ae5d92. Fixes: http://tracker.ceph.com/issues/20983 Signed-off-by: Sage Weil <sage@redhat.com>
xiexingguo
approved these changes
Aug 12, 2017
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we are cloning a blob for a 1 byte logical extent then dirty_range_begin
will equal _end and we won't dirty the source onode (with possibly newly
shared blobs).
Fix by using a separate flag to indicate whether we are dirtying instead
of overloading the begin/end markers for this. Note that even if they
are equal dirty_range will still dirty the shard in question.
This is a result of 0ae5d92.
Fixes: http://tracker.ceph.com/issues/20983
Signed-off-by: Sage Weil sage@redhat.com