rgw: exit early if rgw_bucket_set_attrs() fails #17041
Conversation
There was a problem hiding this comment.
-
Please provide an appropriate PR Title and Commit Title that reflects your fix.
-
What about providing an error message when
rgw_bucket_set_attrs()fails.
https://github.com/dengxiafubi/ceph/blob/ec4fe64ad7bce5bcc597a2da56ef6860ebaba1e8/src/rgw/rgw_op.cc#L4738
Signed-off-by: dengxiafubi 670318146@qq.com
Is this your correct email ID used for signing off ? Use the appropriate email ID for signing off and put this email ID in the .mailmap.
dengxiafubi
changed the title
dengxiafubi
force-pushed
the
EAS-1
branch
4 times, most recently
from
a5779b2
to
f917261
Compare
src/rgw/rgw_op.cc
Outdated
| @@ -4775,6 +4775,11 @@ void RGWDeleteLC::execute() | |||
| } | |||
| } | |||
| op_ret = rgw_bucket_set_attrs(store, s->bucket_info, attrs, &s->bucket_info.objv_tracker); | |||
| if (op_ret < 0) { | |||
| dout(0) << "RGWLC::RGWDeleteLC() failed to set attrs on bucket=" << s->bucket.name | |||
There was a problem hiding this comment.
while you're at it, also move from dout-> ldout(s->cct,0)
There was a problem hiding this comment.
@theanalyst Do you mean move the other dout's in execute() too ?
the returned value of rgw_bucket_set_attrs() reuires exception handling Signed-off-by: dengxiafubi <xhwcqupt@sina.com>
dengxiafubi
changed the title
|
@joscollin update |
|
@theanalyst update |
joscollin
changed the title
|
@joscollin please help to review this pr ,thx |
|
jenkins test docs |
Check for the return value of rgw_bucket_set_attrs() and exit earlier in case of
errors
Signed-off-by: dengxiafubi xhwcqupt@sina.com