osd: fix reqid assignment for reply messages in OpRequest #17060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyx1231st
force-pushed
the
fix_reqid_assignment_in_oprequest
branch
from
b431da8
to
30199ed
Compare
joscollin
requested changes
Aug 17, 2017
src/osd/OpRequest.cc
Outdated
| @@ -38,6 +39,8 @@ OpRequest::OpRequest(Message *req, OpTracker *tracker) : | |||
| reqid = static_cast<MOSDSubOp*>(req)->reqid; | |||
| } else if (req->get_type() == MSG_OSD_REPOP) { | |||
| reqid = static_cast<MOSDRepOp*>(req)->reqid; | |||
| } else if (req->get_type() == MSG_OSD_REPOPREPLY) { | |||
| reqid = static_cast<MOSDRepOpReply*>(req)->reqid; | |||
There was a problem hiding this comment.
It would have been a better design if reqid was private as it is in MOSDOp. Don't know why it is not.
cyx1231st
force-pushed
the
fix_reqid_assignment_in_oprequest
branch
2 times, most recently
from
919a06d
to
4186d9e
Compare
cyx1231st
changed the title
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
|
retest this please |
joscollin
changed the title
tchaikov
approved these changes
Aug 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yingxin Cheng yingxin.cheng@intel.com