Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: use dmclock library client_info_f function dynamically #17063

Merged
merged 1 commit into from Sep 26, 2017

Conversation

bspark8
Copy link
Contributor

@bspark8 bspark8 commented Aug 17, 2017

Use dmclock library client_info_f function dynamically to be able to apply QoS parameter changes at run-time in Ceph and brings in related dmclock library changes.

Copy link
Member

@ivancich ivancich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rebase this on current master? That this PR seems to be modifying files below src/dmclock is a red flag (since we should be modifying the dmclock library directly and then pulling those changes back into ceph). However, I'm guessing some of these changes correspond to
ceph/dmclock#24 and therefore have been pulled into ceph recently. A rebase will help us see what the actual changes are.

to be able to apply QoS parameter changes at runtime in Ceph.

Signed-off-by: bspark <bspark8@sk.com>
@bspark8
Copy link
Contributor Author

bspark8 commented Sep 21, 2017

I finished rebase as you said.
In order to use the client_info_f function dynamically in Ceph, I modified the template parameter in mClockPriorityQueue.h to true.
The dmClock library pull process is skipped because the dmClock latest source (including ceph/dmclock#24) already has been pulled into the current Ceph master.

Thank you.

@ivancich
Copy link
Member

Looks good. Let's run this through the QA to make sure it doesn't introduce problems.

Copy link
Member

@ivancich ivancich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just waiting for QA.

@yuriw yuriw merged commit 85f3227 into ceph:master Sep 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants