Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

osd: adjust osd_min_pg_log_entries #17075

Merged
merged 1 commit into from Aug 23, 2017
Merged

osd: adjust osd_min_pg_log_entries #17075

merged 1 commit into from Aug 23, 2017

Conversation

ivancich
Copy link
Member

Return osd_min_pg_log_entries to its original values, which matches
osd_pg_log_dups_tracked, so the extended dup log is not used in the
general case.

This helps address: http://tracker.ceph.com/issues/21026

Signed-off-by: J. Eric Ivancich ivancich@redhat.com

@ivancich
osd: adjust osd_min_pg_log_entries
1c4df03 
Return osd_min_pg_log_entries to its original values, which matches
osd_pg_log_dups_tracked, so the extended dup log is not used in the
general case.

This helps address: http://tracker.ceph.com/issues/21026

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
@ivancich ivancich requested a review from markhpc August 17, 2017 20:18
@gregsfortytwo
Copy link
Member

I'm fine with this myself, but I'm not sure if we've prepared memory consumption numbers that will need to be adjusted (if we have them, they'll need to change). @markhpc, @jdurgin?

@gregsfortytwo gregsfortytwo removed their assignment Aug 18, 2017
@tchaikov
Copy link
Contributor

jdurgin
jdurgin approved these changes Aug 23, 2017
View reviewed changes
Copy link
Member

@jdurgin jdurgin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good workaround for the initial luminous release. The first point release can have a real fix after it's been through more testing.

@jdurgin jdurgin merged commit db16d50 into ceph:master Aug 23, 2017
@ivancich ivancich deleted the wip-adjust-dup-ops-options branch September 8, 2017 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdurgin jdurgin jdurgin approved these changes

@markhpc markhpc Awaiting requested review from markhpc

Assignees
No one assigned
Labels
core needs-qa performance
Projects
None yet
Milestone
No milestone
5 participants
@ivancich @gregsfortytwo @tchaikov @jdurgin @yuriw