os/bluestore: support calculate cost when using spdk. #17091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yuyuyu101 please help take a look. Thanks. |
|
why need to consider this? |
|
ioc->pending_aios will be used only in KernelDevice.cc, but not used for NVMEDevice.cc. So when use NVMEDevice.cc, we cannot get right transaction cost for throttle_bytes |
|
it's just a cleanup not bug fix, I think? |
|
@yuyuyu101 yup, I agree |
|
retest this please |
yuyuyu101
reviewed
Aug 21, 2017
src/os/bluestore/BlueStore.cc
Outdated
|
|
||
| #ifdef HAVE_SPDK | ||
| ios += txc->ioc.total_nseg; | ||
| dout(0) << "[liupan] " << " ios: " << ios << " total_nseg: " |
Signed-off-by: Pan Liu <wanjun.lp@alibaba-inc.com> Signed-off-by: Ziye Yang <optimistyzy@gmail.com>
|
@yuyuyu101 debug info has been removed, please take a look. BTW, the failed info in "make check" is about jenkins issue, not related to this change. |
|
Jenkins, retest this please. |
|
all commits in this PR are signed |
|
submodules for project are unmodified |
optimistyzy
reviewed
Aug 22, 2017
| @@ -7657,6 +7657,11 @@ void BlueStore::_txc_calc_cost(TransContext *txc) | |||
| for (auto& p : txc->ioc.pending_aios) { | |||
There was a problem hiding this comment.
we may should put this loop in else case
There was a problem hiding this comment.
ioc.pending_aios is not needed for SPDK case.
|
@yuyuyu101 ping? |
yuyuyu101
approved these changes
Aug 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For KernelDevice, _txc_calc_cost has been supported to calc transaction cost. But for spdk NVMEDevice, it is not.
Signed-off-by: Pan Liu wanjun.lp@alibaba-inc.com
Signed-off-by: Ziye Yang optimistyzy@gmail.com