[ceph-volume] Use a delimited CLI output parser instead of JSON #17097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 18, 2017 17:05
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Signed-off-by: Alfredo Deza <adeza@redhat.com>
|
jenkins test ceph-volume tox |
|
jenkins test ceph-volume centos7-create |
|
jenkins test ceph-volume xenial-create |
1 similar comment
|
jenkins test ceph-volume xenial-create |
Signed-off-by: Alfredo Deza <adeza@redhat.com>
|
jenkins test ceph-volume xenial-create |
|
@ktdreyer there is a small change to Debian packaging I had to add that was preventing ceph-volume-systemd (the executable) from being added to the deb package. Xenial tests caught these, which are now passing |
andrewschoen
approved these changes
Aug 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older versions of LVM do not support JSON output. This PR uses LVM's flags to customize the output so that we can parse it providing the same functionality. Specifically the
--reportformatflag does not work on XenialFixes: https://bugzilla.redhat.com/show_bug.cgi?id=1478599