Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vstart.sh: use bluestore as default osd objectstore backend #17100

Merged
merged 1 commit into from Sep 4, 2017
Merged

vstart.sh: use bluestore as default osd objectstore backend #17100

merged 1 commit into from Sep 4, 2017

Conversation

mychoxin
Copy link
Contributor

Signed-off-by: mychoxin mychoxin@gmail.com

@mychoxin mychoxin closed this Aug 19, 2017
@mychoxin mychoxin reopened this Aug 19, 2017
xiexingguo
xiexingguo reviewed Aug 21, 2017
View reviewed changes
src/vstart.sh Outdated
@@ -150,7 +150,8 @@ usage=$usage"\t--mgr_num specify ceph mgr count\n"
usage=$usage"\t--rgw_port specify ceph rgw http listen port\n"
usage=$usage"\t--rgw_frontend specify the rgw frontend configuration\n"
usage=$usage"\t--rgw_compression specify the rgw compression plugin\n"
usage=$usage"\t-b, --bluestore use bluestore as the osd objectstore backend\n"
usage=$usage"\t-b, --bluestore use bluestore as the osd objectstore backend(default)\n"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space before (default)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, please have a look.

@mychoxin
vstart.sh: use bluestore as default osd objectstore backend
657ff03 
Signed-off-by: mychoxin <mychoxin@gmail.com>
@mychoxin mychoxin force-pushed the yuanxin_vstart_default_bluestore branch from 86d4ac4 to 657ff03 Compare August 23, 2017 05:36
@mychoxin mychoxin closed this Aug 24, 2017
@mychoxin mychoxin reopened this Aug 24, 2017
@mychoxin
Copy link
Contributor Author

@xiexingguo what do you think of it ?

xiexingguo
xiexingguo approved these changes Aug 26, 2017
View reviewed changes
Copy link
Member

@xiexingguo xiexingguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine, but need to confirm it doesn't break any test suites

@xiexingguo
Copy link
Member

http://pulpito.ceph.com/xxg-2017-09-01_07:17:41-rados-wip-xxg-testing-2017-09-01-1357-distro-basic-smithi/
http://pulpito.ceph.com/xxg-2017-09-03_12:51:11-rados-wip-xxg-testing-2017-09-01-1357-distro-basic-smithi/

@xiexingguo xiexingguo merged commit 659f891 into ceph:master Sep 4, 2017
@wjwithagen
Copy link
Contributor

@mychoxin @xiexingguo
I think this is going to break FreeBSD testing, since it does not have bluestore yet.

@xiexingguo
Copy link
Member

@mychoxin @xiexingguo
I think this is going to break FreeBSD testing, since it does not have bluestore yet.

Sorry, the lab has no test suites for FreeBSD for now:-)
Maybe we can fix the FreeBSD test suites by explicitly enabling the -f option instead?

@wjwithagen
Copy link
Contributor

Easiest would be to keep old behavour voor FreeBSD and make something during initialization like

if [ `uname`= FreeBSD ]; then
    ....
else
    .....
fi

And perhaps not bother with the default word.

Also i noticed that the #! shebang has been set back to /bin/bash
Where it should have been /usr/bin/env bash . But that was not your doing
So I'll have to look for the author for that.

@wjwithagen
Copy link
Contributor

Please ignore the remark about /usr/bin/env, since that commit is post your commit.

@mychoxin mychoxin mentioned this pull request Sep 5, 2017
Closed
@mychoxin
Copy link
Contributor Author

mychoxin commented Sep 5, 2017

#17492

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiexingguo xiexingguo xiexingguo approved these changes

Assignees
No one assigned
Labels
cleanup needs-qa tools wip-xxg-testing
Projects
None yet
Milestone
No milestone
3 participants
@mychoxin @xiexingguo @wjwithagen