NVMDevice: fix issued caused by #17002 #17112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liupan1111
reviewed
Aug 21, 2017
|
|
||
| public: | ||
| aio_callback_t aio_callback; | ||
| void *aio_callback_priv; |
There was a problem hiding this comment.
I think keep aio_callback and aio_callback_priv as protected, and set Task as friend is a better choice.
There was a problem hiding this comment.
If we set task as friend, the patch will become complicated since task is only defined and used in nvmedevice.cc
|
Signed-off-by should be added to make jenkins happy |
Patch ceph#17002 breaks running osd when using spdk, and this patch can fix this. Signed-off-by: Ziye Yang <optimistyzy@gmail.com>
|
@liupan1111 signed off is added |
|
lgtm |
|
Jenkins, retest this please |
liupan1111
approved these changes
Aug 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch #17002 breaks running osd when using spdk, and
this patch can fix this.