Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc/conf.py: do not set html_use_smartypants explicitly #17127

Merged
merged 2 commits into from Aug 22, 2017

Conversation

tchaikov
Copy link
Contributor

No description provided.

since manpages are built as part of "make" process, we can dispense with
the manual steps.

Signed-off-by: Kefu Chai <kchai@redhat.com>
because it's deprecated, and is on by default in the specified sphinx
version (v1.6.3):

this change silences following warning:

build-doc/virtualenv/local/lib/python2.7/site-packages/sphinx/environment/__init__.py:683:
RemovedInSphinx17Warning: html_use_smartypants option is deprecated.
Smart quotes are on by default; if you want to disable or customize
them, use the smart_quotes option in docutils.conf.
  RemovedInSphinx17Warning)

Signed-off-by: Kefu Chai <kchai@redhat.com>
Copy link
Member

@dmick dmick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@alfredodeza
Copy link
Contributor

Since we've upgraded Sphinx, this option is now deprecated as it defaults to True

http://www.sphinx-doc.org/en/stable/config.html#confval-html_use_smartypants

@alfredodeza alfredodeza merged commit 9aa4496 into ceph:master Aug 22, 2017
@tchaikov tchaikov deleted the wip-doc-cleanups branch August 22, 2017 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants